Tesla: Improve accuracy on temperature value #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matvey83
reviewed
Jan 29, 2024
Comment on lines
444
to
445
| max_temp = (rx_frame.data.u8[2] * 5) - 400; //40.0*C offset, value for instance 85 = 8.5*C | ||
| min_temp = (rx_frame.data.u8[3] * 5) - 400; //40.0*C offset, value for instance 85 = 8.5*C |
There was a problem hiding this comment.
A comment is needed to explain the reason for 5 multiplier and 40 degree offset.
There was a problem hiding this comment.
Comment updated in 7f3c6ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR improves the accuracy on the reported minimum/maximum temperature value read via CAN.
Why
Credit to frenetic over on the Discord server for noticing this bug!
How
The original calculation rounded every .5° downwards. For instance if battery temperature was 8.5C , the code reported back 8.0C
Old:
temp = rx_frame.data.u8[2]; max_temp = (temp * 0.5) - 40;New:
max_temp = (rx_frame.data.u8[2] * 5) - 400;